After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769997 - file-operations: fix duplication status string
file-operations: fix duplication status string
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-16 15:56 UTC by Ernestas Kulik
Modified: 2016-08-21 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
file-operations: fix duplication status string (1.74 KB, patch)
2016-08-16 15:56 UTC, Ernestas Kulik
none Details | Review
file-operations: fix duplication status string (1.86 KB, patch)
2016-08-16 16:03 UTC, Ernestas Kulik
none Details | Review
file-operations: fix duplication status string (1.87 KB, patch)
2016-08-16 16:05 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2016-08-16 15:56:49 UTC
Stumbled upon this while taking a look bug 769383.
Comment 1 Ernestas Kulik 2016-08-16 15:56:53 UTC
Created attachment 333431 [details] [review]
file-operations: fix duplication status string

The status string for file duplication currently displays the index of a
file and adds one to it, which results in funky strings (e.g.
“Duplicating 3 file in X”). The desired result is the total count of
files being displayed. This commit changes the code to reflect that.
Comment 2 Ernestas Kulik 2016-08-16 16:03:07 UTC
Created attachment 333432 [details] [review]
file-operations: fix duplication status string

There are a couple of problems with the status string during file
duplication:
  1. The status string is constructed by calling ngettext()
  with the index of the file plus one.
  2. nautilus_progress_info_take_status() is called with the total count
  of files plus one.

These two combined result in funky status string (e.g. “duplicating 3
file in X).

This commit fixes both of those problems.
Comment 3 Ernestas Kulik 2016-08-16 16:05:20 UTC
Created attachment 333433 [details] [review]
file-operations: fix duplication status string

There are a couple of problems with the status string during file
duplication:
  1. The status string is constructed by calling ngettext()
  with the index of the file plus one.
  2. nautilus_progress_info_take_status() is called with the total count
  of files plus one.

These two combined result in funky status strings (e.g. “duplicating 3
file in X”).

This commit fixes both of those problems.
Comment 4 Carlos Soriano 2016-08-20 18:39:04 UTC
Review of attachment 333433 [details] [review]:

ohhh
Comment 5 Ernestas Kulik 2016-08-21 16:45:36 UTC
Attachment 333433 [details] pushed as 374718f - file-operations: fix duplication status string