After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769819 - qtdemux: Fix segmentation fault in check_update_duration ()
qtdemux: Fix segmentation fault in check_update_duration ()
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-13 02:26 UTC by Seungha Yang
Modified: 2016-08-15 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtdemux-Fix-segmentation-fault-in-check_update_durat.patch (1.31 KB, patch)
2016-08-13 02:26 UTC, Seungha Yang
none Details | Review

Description Seungha Yang 2016-08-13 02:26:02 UTC
qtdemux: Fix segmentation fault in check_update_duration ()

In the gst_qtdemux_stream_flush_segments_data () method, all segments
related variables should be set as default.

When check_update_duration () method was called with following condition,
demux will try to do invalid memory access
* dummy segment had been created previously.
  This will allocate memory for stream->segments with setting dummy_segment = TRUE
* gst_qtdemux_stream_flush_segments_data () has been called by some reason.
  This will free stream->segments without setting dummy_segment = FALSE

Note that, check_update_duration () will try to update duration of stream->segments
if dummy_segment was set to TRUE
Comment 1 Seungha Yang 2016-08-13 02:26:56 UTC
Created attachment 333201 [details] [review]
qtdemux-Fix-segmentation-fault-in-check_update_durat.patch
Comment 2 Seungha Yang 2016-08-14 01:46:20 UTC
Please ignore this ticket. It happen only my customized environment.