GNOME Bugzilla – Bug 769788
Fix stacking order of flatpak portals on Wayland
Last modified: 2016-08-29 17:29:24 UTC
This adds support for using xdg-foreign to stack portal dialogs correctly under Wayland. Required mutter patches can be found in bug 769786.
Created attachment 333168 [details] [review] wayland: Add API for creating exported window handles Using the xdg_foreign protocol, expose a way to get handles to windows that may be shared between processes.
Created attachment 333169 [details] [review] window: Add Wayland implementation of gtk_window_export_handle
Created attachment 333170 [details] [review] wayland: Add API for setting an exported as a parent Add an API that enables an application to, given an exported window handle, set its own window as a transient of the window associated with the exported window handle.
Review of attachment 333168 [details] [review]: looks good to me
Review of attachment 333169 [details] [review]: ok
Review of attachment 333170 [details] [review]: ::: gdk/wayland/gdkwindow-wayland.c @@ +3303,3 @@ + * + * Stability: unstable + */ Do you not consider this stable yet ?
(In reply to Matthias Clasen from comment #6) > Review of attachment 333170 [details] [review] [review]: > > ::: gdk/wayland/gdkwindow-wayland.c > @@ +3303,3 @@ > + * > + * Stability: unstable > + */ > > Do you not consider this stable yet ? The idea was to try it out for a release and then mark it as stable. The underlying protocol is also not declared stable yet.
If 3.22 becomes the last API stable/feature frozen release of the 3.x API series then API introduced in this cycle will have to be stable.
(In reply to Emmanuele Bassi (:ebassi) from comment #8) > If 3.22 becomes the last API stable/feature frozen release of the 3.x API > series then API introduced in this cycle will have to be stable. I thought that was at least 3.24? FWIW, I'd rather see it be 3.24 since we still need to make a backward incompatible "xdg_shell" bump, and would be nice if that could be done bofore we declare "gtk3" stable.
do you mean the bump to v6, or another bump ?
(In reply to Matthias Clasen from comment #10) > do you mean the bump to v6, or another bump ? I mean yet another bump. My intention is to try to declare "xdg-shell" stable for 3.24. Not until then can we promise backward compatibility without having a unstable old unused protocol implementation in every compositor GTK+ 3 is intended to run on for ever.
Just landed the mutter patches. What should we do about the stability tag of this API?
I would suggest that we just declare the api stable. It doesn't directly expose wayland protocol objects. As long as we have optional window ids at all, we should be able to keep it working. No ?
Attachment 333168 [details] pushed as 127d2ac - wayland: Add API for creating exported window handles Attachment 333169 [details] pushed as f98c9fe - window: Add Wayland implementation of gtk_window_export_handle Attachment 333170 [details] pushed as 340b596 - wayland: Add API for setting an exported as a parent