After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769680 - stop process needs confirm, NOT within 1pix of mouse, warning about stopping X: dataloss
stop process needs confirm, NOT within 1pix of mouse, warning about stopping ...
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: process list
3.20.x
Other Linux
: Normal enhancement
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-09 17:24 UTC by Pedro Beja
Modified: 2016-08-10 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
UI issue (87.84 KB, image/png)
2016-08-09 17:59 UTC, Pedro Beja
Details

Description Pedro Beja 2016-08-09 17:24:08 UTC
Hi,

Forwarding a bug from Debian-BTS:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760381 by Charles Evans.

------------
Dear Maintainer,

In the processes tab, any attempt to access the context menu 
is a 1 pixel slip away from stopping the process being examined.

If one is examining Xorg, 
that is 1 pixel away from locking up the desktop. 

Ctrl-alt-backspace fails, ctrl-alt-F1 fails; AFAIKT
only magic-sysreq can limit dataloss to whatever was running on X.

IMHO: 

1. The user should be warned before stopping a process
2. The user should be warned specifically a second time of the consequences of stopping X, if the process is Xorg.
3. The stop choice should NOT be near the mouse pointer for any rtclick position.

FYI: version 3.12.2-1 has the same problem.

Thanks
------------

thanks
regards
Pedro Beja
Comment 1 Robert Roth 2016-08-09 17:47:03 UTC
I agree that the stop process action should be confirmed, I can implement that (we already have a confirmation dialog for end/kill, the same could be applied for stop too, and I don't think it would be useful for Continue). However, I would like to avoid special-casing Xorg, systemd, wayland, or other processes with a second confirmation/warning, as the list of exceptions could get potentially long. We can't hardcode every process which should not be stopped to avoiding damage, and there is no indication in the process properties themselves about whether the process is a vital one or just a helper or anything else.

Regarding the rightclick menu and stop menuitem positioning: I could rearrange the item to start with Properties, Memory Maps and Open files (these not being dangerous actions), followed by the change priority, followed by the process status actions, which could lead to unwanted consequences, but would require confirmation.

Would the proposed solution solve the problem for you?
Comment 2 Pedro Beja 2016-08-09 17:50:52 UTC
Hi Robert,

yep that seems to be great :)

thanks
Pedro Beja
Comment 3 Pedro Beja 2016-08-09 17:59:13 UTC
Created attachment 333012 [details]
UI issue
Comment 4 Pedro Beja 2016-08-09 18:00:20 UTC
even though there is still an issue... the actions of context menu may vary according to the mouse position please see the above screenshot.

atm I have no ideia how to solve this.
Comment 5 Robert Roth 2016-08-10 00:29:03 UTC
(In reply to Pedro Beja from comment #4)
> even though there is still an issue... the actions of context menu may vary
> according to the mouse position please see the above screenshot.
> 
> atm I have no ideia how to solve this.

I think we will have to live with that for now. Adding a confirmation to the stop process will reduce the risk of making your computer unusable, even if you mistakenly rightclick+select Stop process, you will have to confirm. Having 1 rightclick + 2 leftclicks at different places by mistake has a very low probability.
Comment 6 Robert Roth 2016-08-10 00:55:52 UTC
Quick summary: process context menu reordered, confirmation required on stopping a process.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 7 Pedro Beja 2016-08-10 11:55:42 UTC
yeah the box confirmation will be riskless :)

thanks Robert