After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769616 - Don't include git.mk in makefile
Don't include git.mk in makefile
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-08 03:03 UTC by Michael Catanzaro
Modified: 2016-08-21 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't include git.mk in makefile (864 bytes, patch)
2016-08-08 03:03 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2016-08-08 03:03:31 UTC 
This causes git.mk in parent projects to overwrite libgd's .gitignore file.
Comment 1 Michael Catanzaro 2016-08-08 03:03:34 UTC 
Created attachment 332904 [details] [review]
Don't include git.mk in makefile

We have a .gitignore committed into version control, so we shouldn't be
overwriting it. This defeats the purpose of using git.mk as we wind up
with a dirty subproject after every build due to make rewriting our
tracked .gitignore. And libgd itself does not use git.mk, so it
shouldn't be here.
Comment 2 Michael Catanzaro 2016-08-16 15:24:46 UTC 
(ping maintainers)
Comment 3 Michael Catanzaro 2016-08-21 20:54:20 UTC 
This is clearly correct, extremely annoying for anything that uses both git.mk and a libgd submodule, and only affects .gitignores, so let's do it.
Comment 4 Michael Catanzaro 2016-08-21 20:54:44 UTC 
Attachment 332904 [details] pushed as 1f2e074 - Don't include git.mk in makefile