After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769482 - autotools: Make the Run button work when builddir != srcdir
autotools: Make the Run button work when builddir != srcdir
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-03 18:20 UTC by Matthew Leeds
Modified: 2016-08-03 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
autotools: Make the Run button work when builddir != srcdir (8.58 KB, patch)
2016-08-03 18:20 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Matthew Leeds 2016-08-03 18:20:43 UTC 
I verified that this patch works, but it may not be the cleanest way to accomplish it.
Comment 1 Matthew Leeds 2016-08-03 18:20:46 UTC 
Created attachment 332646 [details] [review]
autotools: Make the Run button work when builddir != srcdir

To make the Run button work, Builder looks in a project's directory for
a Makefile, which doesn't work when the build directory differs from the
source code directory, such as when you're building in ~/.cache/.... This
commit makes Builder look for Makefiles in the build directory, as determined
by an IdeAutotoolsBuilder instance. It should be okay not to check for
Makefile.am files since this code is only used for autotools projects.
Comment 2 Christian Hergert 2016-08-03 18:30:37 UTC 
Review of attachment 332646 [details] [review]:

Nice work, looks good
Comment 3 Christian Hergert 2016-08-03 18:30:37 UTC 
Review of attachment 332646 [details] [review]:

Nice work, looks good
Comment 4 Christian Hergert 2016-08-03 18:30:37 UTC 
Review of attachment 332646 [details] [review]:

Nice work, looks good
Comment 5 Matthew Leeds 2016-08-03 19:28:53 UTC 
Pushed as commit 095985e0d05932ec93b6f1c065527a77727380f8