After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769454 - genesis: Update the new-project action to use the new view
genesis: Update the new-project action to use the new view
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-03 00:35 UTC by Matthew Leeds
Modified: 2016-08-03 01:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
genesis: Update the new-project action to use the new view (3.94 KB, patch)
2016-08-03 00:35 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Matthew Leeds 2016-08-03 00:35:19 UTC 
I noticed the "New Project" menu item wasn't working; this should fix it.
Comment 1 Matthew Leeds 2016-08-03 00:35:23 UTC 
Created attachment 332601 [details] [review]
genesis: Update the new-project action to use the new view

The New Project view used to be handled by an IdeGenesisPerspective, but
is now handled by GbpCreateProjectGenesisAddin. The application's
new-project action (which can be accessed via the menu in the GNOME
Shell top bar) stopped working when the switch was made. This commit
fixes the issue by adding an interface to the IdeGreeterPerspective to
show a genesis view, and calling it from ide-application-actions.c.
Comment 2 Christian Hergert 2016-08-03 00:39:12 UTC 
Review of attachment 332601 [details] [review]:

sorta weird due to the plugin nature of things. Looks fine to me though.
Comment 3 Matthew Leeds 2016-08-03 00:43:21 UTC 
Yeah I wondered if there's a way not to hard-code the name of the add-in but I couldn't think of one.
Comment 4 Matthew Leeds 2016-08-03 01:11:38 UTC 
Pushed as commit 7746c8cd5b3290ae4d39a0aa27100254b715c990