After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769438 - ui: Add a keyboard shortcut to trigger fullscreen
ui: Add a keyboard shortcut to trigger fullscreen
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 769816 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-02 15:45 UTC by Adrien Plazas
Modified: 2016-08-26 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Add ApplicationWindow.handle_collection_key_event() (1.90 KB, patch)
2016-08-26 06:45 UTC, Adrien Plazas 		committed Details | Review
ui: Add key bindings to toggle fullscreen (1.67 KB, patch)
2016-08-26 06:45 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-08-02 15:45:56 UTC 
Ctrl+F is probably fine, it shouldn't clash with games and wont clash with the search bar as fullscreen and search will never be available at the same time.
Comment 1 Bastien Nocera 2016-08-02 17:34:43 UTC 
Ctrl+F and F11, usually.

We also use "raw" keys when there aren't any widgets on screen, so, at least when playing a "console" (eg. non-keyboard) game, I'd advise to also bind "F" as a way to toggle fullscreen, and Esc to switch fullscreen off.
Comment 2 Bastien Nocera 2016-08-02 17:35:17 UTC 
> We also use "raw" keys when there aren't any widgets on screen

In totem...
Comment 3 Bastien Nocera 2016-08-13 00:35:28 UTC 
*** Bug 769816 has been marked as a duplicate of this bug. ***
Comment 4 Adrien Plazas 2016-08-26 06:45:45 UTC 
Created attachment 334202 [details] [review]
ui: Add ApplicationWindow.handle_collection_key_event()

Add the handle_collection_key_event() method to ApplicationWindow to
handle collection specific key bindings.

This will help to make the code easier to read as more key bindings are
going to be added in the next commit.
Comment 5 Adrien Plazas 2016-08-26 06:45:49 UTC 
Created attachment 334203 [details] [review]
ui: Add key bindings to toggle fullscreen

Add the Ctrl+F and F11 key bindings to toggle fullscreen and add the
Escape key binding to restore the window.
Comment 6 Adrien Plazas 2016-08-26 06:55:55 UTC 
Attachment 334202 [details] pushed as 8d33278 - ui: Add ApplicationWindow.handle_collection_key_event()
Attachment 334203 [details] pushed as 8c4416d - ui: Add key bindings to toggle fullscreen