After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769378 - Deprecate gvfs utils in favour of new gio tool
Deprecate gvfs utils in favour of new gio tool
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-01 11:47 UTC by Ondrej Holy
Modified: 2016-10-11 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
programs: Deprecate gvfs utils in favour of new gio tool (144.30 KB, patch)
2016-08-01 11:48 UTC, Ondrej Holy
none Details | Review
programs: Deprecate gvfs utils in favour of new gio tool (144.45 KB, patch)
2016-09-29 11:10 UTC, Ondrej Holy
committed Details | Review
man: Update pages for deprecated gvfs utils (79.72 KB, patch)
2016-10-04 08:44 UTC, Ondrej Holy
committed Details | Review
man: Add missing author section (1.12 KB, patch)
2016-10-11 09:05 UTC, Ondrej Holy
committed Details | Review

Description Ondrej Holy 2016-08-01 11:47:23 UTC
See:
https://git.gnome.org/browse/glib/commit/?id=9edba4e
Comment 1 Ondrej Holy 2016-08-01 11:48:51 UTC
Created attachment 332475 [details] [review]
programs: Deprecate gvfs utils in favour of new gio tool

New gio cmd tool has been added in GLib. The tool collects and unifies the various gvfs- utils. The gvfs- utils use GIO APIs anyway, so it makes sense for them to be part of GLib and doesn't longer make sense to maintain them here. Let's remove them and add scripts spawning new gio tool with deprecation warning instead.
Comment 2 Matthias Clasen 2016-09-27 13:09:38 UTC
looks good to me
Comment 3 Bastien Nocera 2016-09-27 14:19:49 UTC
> gvfs-mount: deprecated.in

You should add "Makefile" as a dependency of all the targets.

> sh -c "$replacement $@"

Why not exec? Are you sure about the quoting here as well (like arguments with spaces such as:
gvfs-open "foo bar.txt"
?
Comment 4 Ondrej Holy 2016-09-29 11:07:25 UTC
Thanks both of you for the reviews! Will update...
Comment 5 Ondrej Holy 2016-09-29 11:10:32 UTC
Created attachment 336499 [details] [review]
programs: Deprecate gvfs utils in favour of new gio tool

New gio cmd tool has been added in GLib. The tool collects and unifies
the various gvfs- utils. The gvfs- utils use GIO APIs anyway, so it
makes sense for them to be part of GLib and doesn't longer make sense to
maintain them here. Let's remove them and add scripts spawning new gio
tool with deprecation warning instead.
Comment 6 Ondrej Holy 2016-10-03 14:20:09 UTC
Attachment 336499 [details] pushed as 2f28fa4 - programs: Deprecate gvfs utils in favour of new gio tool
Comment 7 Ondrej Holy 2016-10-04 08:44:12 UTC
Created attachment 336859 [details] [review]
man: Update pages for deprecated gvfs utils

Commit 2f28fa4 replaced various gvfs- utils in favour of new gio cmd
tool. Update also relevant man pages with mention that they have been
deprecated.
Comment 8 Ondrej Holy 2016-10-04 08:45:27 UTC
Comment on attachment 336859 [details] [review]
man: Update pages for deprecated gvfs utils

commit c960ddaf
Comment 9 Ondrej Holy 2016-10-11 09:05:31 UTC
Created attachment 337389 [details] [review]
man: Add missing author section

Add missing author section in order to avoid the following warnings:
Warn: meta author : no refentry/info/author
Note: meta author : see http://docbook.sf.net/el/author
Warn: meta author : no author data, so inserted a fixme
Comment 10 Ondrej Holy 2016-10-11 09:06:10 UTC
Comment on attachment 337389 [details] [review]
man: Add missing author section

Attachment 337389 [details] pushed as f998067 - man: Add missing author section