After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769376 - aiffparse: seeking in aiff can create audio artifacts if there's extra data at the end
aiffparse: seeking in aiff can create audio artifacts if there's extra data a...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-01 09:52 UTC by Bernhard Miller
Modified: 2016-08-16 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the issue (1.45 KB, patch)
2016-08-01 09:52 UTC, Bernhard Miller 		committed Details | Review

Description Bernhard Miller 2016-08-01 09:52:17 UTC 
Created attachment 332468 [details] [review]
Patch to fix the issue

After seeking in aiff files the information about the data end offset is discarded, leading to audio artifacts with metadata chunks at the end of a file. The attached patch retains the end offset information after a seek event.
Comment 1 Tim-Philipp Müller 2016-08-06 16:09:26 UTC 
Thanks for the patch!

commit 9171fa9c19a50181bd90458d98abc280bf2c2b89
Author: Bernhard Miller <bernhard.miller@streamunlimited.com>
Date:   Mon Aug 1 11:45:30 2016 +0200

    aiffparse: keep end_offset when seeking
    
    After seeking in aiff files the information about the data end offset is
    discarded, leading to audio artifacts with metadata chunks at the end of
    a file.
    This patch retains the end offset information after a seek event.
    
    https://bugzilla.gnome.org//show_bug.cgi?id=769376