After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769102 - [PATCH] Fix directory creation in icons/Symbolic-Inverted/Makefile.am
[PATCH] Fix directory creation in icons/Symbolic-Inverted/Makefile.am
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.9.4
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-07-22 23:20 UTC by Sebastian Pipping
Modified: 2016-07-23 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for icons/Symbolic-Inverted/Makefile.am (1.46 KB, patch)
2016-07-22 23:20 UTC, Sebastian Pipping 		none Details | Review

Description Sebastian Pipping 2016-07-22 23:20:46 UTC 
Created attachment 332018 [details] [review]
Patch for icons/Symbolic-Inverted/Makefile.am

Hi there!


I would like to share a patch for something that looks like a build-system bug to me.  File icons/Symbolic-Inverted/Makefile.am reads

  mkdir -p `dirname $<` && cp -f $< $@

a few times.  It re-creates existing source directories rather than creating the needed output directories.  The fixed version seems to be:

  mkdir -p `dirname $@` && cp -f $< $@
                    ^^

The bug was reported by Kent Fredric at https://bugs.gentoo.org/show_bug.cgi?id=589394 .  A patch of mine is attached.  Please consider application in Git.  Thank you!

Best



Sebastian
Comment 1 Jehan 2016-07-23 12:40:43 UTC 
Looks fine to me.

commit 42420c3c4d6c2e22d1184c8bd20bccf49fa7b4d2
Author: Sebastian Pipping <sebastian@pipping.org>
Date:   Sat Jul 23 01:02:10 2016 +0200

    Bug 769102: fix creation of output directories for inverted icons.
    
    https://bugs.gentoo.org/show_bug.cgi?id=589394


Thanks for the patch!