Created attachment 331673 [details] [review]
roomList: Minor clean up

Split out a helper function to get rid of nested ifs.

Created attachment 331674 [details] [review]
roomList: Connect channel signals immediately if possible

We use the channel's ::message-received and ::pending-message-removed
signals to mark rooms as active/inactive and update the highlight
counter. Currently we are only connecting to those signals when the
room's channel changed, so we fail to update rows for rooms that
already had a channel when added to the list. While this is not the
common case, it can still happen, e.g. when someone initiates a
private chat with us or when re-launched by mission-control after
a crash.

Review of attachment 331673 [details] [review]:

looks good to me, one question:

::: src/roomList.js
@@ +97,3 @@
             context.add_class('inactive');
         else
             context.remove_class('inactive');

i didnt find an answer in the doumentation for GtkStyleContext but could there possibly be a scenario where multiple 'inactive' classes can be added and then when we remove inactive classes we dont get all of them removed? or is gtk clever and attempts only to add classes if they aren't already there?

Review of attachment 331674 [details] [review]:

looks good to me.

(In reply to Bastian Ilsø from comment #3)
> or is gtk clever and attempts only to add classes if they aren't already there?

It's clever:
https://git.gnome.org/browse/gtk+/tree/gtk/gtkcssnodedeclaration.c#n296

Attachment 331673 [details] pushed as ee00e30 - roomList: Minor clean up
Attachment 331674 [details] pushed as 5a0d871 - roomList: Connect channel signals immediately if possible