After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768843 - bad: fix leaks in tests
bad: fix leaks in tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-15 12:18 UTC by Guillaume Desmottes
Modified: 2016-07-18 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
autovideoconvert: fix bus leak (1.22 KB, patch)
2016-07-15 12:18 UTC, Guillaume Desmottes 		committed Details | Review
audiomixer: fix bus leak (900 bytes, patch)
2016-07-15 12:18 UTC, Guillaume Desmottes 		committed Details | Review
camerabin: fix bus leaks in test (3.69 KB, patch)
2016-07-15 12:18 UTC, Guillaume Desmottes 		committed Details | Review
adaptive demux: fix bus leaks in tests (1.85 KB, patch)
2016-07-15 12:18 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2016-07-15 12:18:11 UTC 
.
Comment 1 Guillaume Desmottes 2016-07-15 12:18:35 UTC 
Created attachment 331573 [details] [review]
autovideoconvert: fix bus leak

gst_bus_remove_signal_watch() has to be called to release the ref taken
by gst_bus_add_signal_watch().
Comment 2 Guillaume Desmottes 2016-07-15 12:18:41 UTC 
Created attachment 331574 [details] [review]
audiomixer: fix bus leak

gst_bus_remove_signal_watch() has to be called to release the ref taken
by gst_bus_add_signal_watch().
Comment 3 Guillaume Desmottes 2016-07-15 12:18:46 UTC 
Created attachment 331575 [details] [review]
camerabin: fix bus leaks in test

Use gst_bus_remove_watch() instead of g_source_remove() to remove the
watch so the extra ref owned by gst_bus_add_watch() is released as well.
Comment 4 Guillaume Desmottes 2016-07-15 12:18:51 UTC 
Created attachment 331576 [details] [review]
adaptive demux: fix bus leaks in tests
Comment 5 Tim-Philipp Müller 2016-07-18 11:46:52 UTC 
Thanks!

commit b3b764999ad717e876044ee2d88000172da4edd6
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Jul 15 10:31:35 2016 +0200

    tests: fix bus leak
    
    gst_bus_remove_signal_watch() has to be called to release the ref
    taken by gst_bus_add_signal_watch().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768843