After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768810 - core: add a couple of transfer annotations
core: add a couple of transfer annotations
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-14 14:45 UTC by Guillaume Desmottes
Modified: 2016-07-15 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pad: annotate @event in gst_pad_store_sticky_event (676 bytes, patch)
2016-07-14 14:45 UTC, Guillaume Desmottes 		committed Details | Review
query: add transfer annotation to @¢aps in gst_query_set_caps_result (939 bytes, patch)
2016-07-14 14:45 UTC, Guillaume Desmottes 		rejected Details | Review

Description Guillaume Desmottes 2016-07-14 14:45:12 UTC 
While tracking leaks I wasn't sure if a coupe of args were transferred or not so I added a transfer annotation to make it clearer.
Comment 1 Guillaume Desmottes 2016-07-14 14:45:49 UTC 
Created attachment 331501 [details] [review]
pad: annotate @event in gst_pad_store_sticky_event
Comment 2 Guillaume Desmottes 2016-07-14 14:45:56 UTC 
Created attachment 331502 [details] [review]
query: add transfer annotation to @¢aps in gst_query_set_caps_result
Comment 3 Tim-Philipp Müller 2016-07-15 11:52:59 UTC 
I'm reluctant about these really, by default things generally do not take ownership.

I have pushed the annotation for _store_sticky_event(), but I'm rejecting the one for _set_caps_result() because there the convention is pretty clear, set=no transfer and take = transfer.

commit 2a0bba69e1d1966afda8a1265a74bf072fee67df
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Jul 14 16:40:22 2016 +0200

    pad: add g-i transfer annotatation to _store_sticky_event()
    
    For clarity.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768810