GNOME Bugzilla – Bug 768566
encoding-profile: Unify caps cleanup code with the missing-plugins / descriptions code
Last modified: 2018-05-06 15:12:36 UTC
See commit messages
Created attachment 331076 [details] [review] encoding-profile: Use common copy_and_clean_caps() function to clean up caps when creating an encoding profile from discoverer info It's also removing lots of other irrelevant fields.
Created attachment 331077 [details] [review] missing-plugins: Remove some other fields when cleaning up caps Caps are cleaned up for missing plugins, and for creating encoding profiles and caps descriptions. Fields like streamheader, parsed, framed, stream-format and alignment are not relevant here. The last ones all because a parser will take care of them.
Review of attachment 331076 [details] [review]: The main problem here now is that we would remove width/height/etc too... which is probably wanted for the "format" of the encoding-profile, but they should be part of the "restriction" (rescaling, etc). However it's not clear how we could generate the restriction caps here. Ideas?
commit 48324cab38397639143750c7f800e7bffa4eb009 Author: Sebastian Dröge <sebastian@centricular.com> Date: Fri Jul 8 16:43:05 2016 +0300 encoding-profile: Remove some more fields from the caps when creating from discoverer info parsed, framed, stream-format and alignment are only relevant for parsers and should not matter here. We still want to be able to use an encoder that can only output byte-stream if the input was avc. https://bugzilla.gnome.org/show_bug.cgi?id=768566 commit 0e7cdee6c817ced7eba90dbecc421d0638595317 Author: Sebastian Dröge <sebastian@centricular.com> Date: Fri Jul 8 15:45:25 2016 +0300 missing-plugins: Remove some other fields when cleaning up caps Caps are cleaned up for missing plugins, and for creating encoding profiles and caps descriptions. Fields like streamheader, parsed, framed, stream-format and alignment are not relevant here. The last ones all because a parser will take care of them. https://bugzilla.gnome.org/show_bug.cgi?id=768566
So what's missing here is to unify these caps cleanups.
Not easily doable and not that important. Not worth keeping this bug open