After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768411 - libidemm: Remove unnecessary _CONVERSION() for GDBusProxy
libidemm: Remove unnecessary _CONVERSION() for GDBusProxy
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-04 19:25 UTC by Matthew Leeds
Modified: 2016-07-05 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libidemm: Remove unnecessary _CONVERSION() for GDBusProxy (2.19 KB, patch)
2016-07-04 19:25 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Matthew Leeds 2016-07-04 19:25:16 UTC 
Just trying to clean up old TODOs
Comment 1 Matthew Leeds 2016-07-04 19:25:19 UTC 
Created attachment 330865 [details] [review]
libidemm: Remove unnecessary _CONVERSION() for GDBusProxy

Thanks to commit 69fad0acec4ee0cbefeb5b4d4ccb362415e848cf in glibmm,
gmmproc now knows how to convert GDBusProxy* to
Glib::RefPtr<Gio::DBus::Proxy> so we no longer need this _CONVERSION()
sattement. See https://bugzilla.gnome.org/show_bug.cgi?id=764547 for more
information.
Comment 2 Christian Hergert 2016-07-04 20:55:29 UTC 
Review of attachment 330865 [details] [review]:

LGTM
Comment 3 Matthew Leeds 2016-07-05 13:31:04 UTC 
Pushed as 543c1df7b1a27c2816d21b3e690f13dfc77197bc