After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768356 - vim: Check for open buffer in :bnext and :bprev commands
vim: Check for open buffer in :bnext and :bprev commands
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-04 04:36 UTC by Matthew Leeds
Modified: 2016-07-05 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vim: Check for open buffer in :bnext and :bprev commands (2.45 KB, patch)
2016-07-04 04:36 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Matthew Leeds 2016-07-04 04:36:50 UTC 
See the commit message for an explanation.
Comment 1 Matthew Leeds 2016-07-04 04:36:53 UTC 
Created attachment 330822 [details] [review]
vim: Check for open buffer in :bnext and :bprev commands

The vim commands :bnext and :bprev let the user switch to another
buffer. If those commands are executed without any buffers open,
ide_widget_action() fails and emits a warning. This commit checks if any
buffers are open, and if not the command gracefully gives up. This
matches vim's behavior.
Comment 2 Christian Hergert 2016-07-04 04:52:20 UTC 
Review of attachment 330822 [details] [review]:

LGTM
Comment 3 Matthew Leeds 2016-07-05 13:31:51 UTC 
Pushed as commit bd41b3fa1641e13067c78670a371576e31ebaf4d