After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768316 - overview: Move ::scroll-event signal handling (again)
overview: Move ::scroll-event signal handling (again)
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-02 15:52 UTC by Florian Müllner
Modified: 2016-07-05 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overview: Move ::scroll-event signal handling (again) (2.36 KB, patch)
2016-07-02 15:52 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-07-02 15:52:33 UTC 
See patch.
Comment 1 Florian Müllner 2016-07-02 15:52:40 UTC 
Created attachment 330791 [details] [review]
overview: Move ::scroll-event signal handling (again)

Commit c39ffa111 moved the signal handling from the controls- to the
background-group to enable scrolling on non-primary monitors.
However this broke scrolling on reactive overview elements as the
workspace switcher, as they're not descendants of the background.
To fix, move scroll-event handling to the overview group itself,
which is the common ancestor of all overview elements.
Comment 2 Rui Matos 2016-07-05 15:27:09 UTC 
Review of attachment 330791 [details] [review]:

right, looks good
Comment 3 Florian Müllner 2016-07-05 15:48:19 UTC 
Attachment 330791 [details] pushed as 99b5e10 - overview: Move ::scroll-event signal handling (again)