After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768292 - Empty Graphics string in gnome-control-center running under llvmpipe
Empty Graphics string in gnome-control-center running under llvmpipe
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
3.21.x
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-01 17:12 UTC by Michael Catanzaro
Modified: 2018-01-09 20:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check-accelerated: export renderer string also for llvmpipe (3.16 KB, patch)
2016-07-01 17:12 UTC, Michael Catanzaro 		committed Details | Review
tools: don't check software rendering before GLES helper (5.66 KB, patch)
2018-01-09 16:03 UTC, Mario Sánchez Prada 		committed Details | Review

Description Michael Catanzaro 2016-07-01 17:12:36 UTC 
The GLES helper work broke the Graphics string in gnome-control-center when running under llvmpipe.
Comment 1 Michael Catanzaro 2016-07-01 17:12:39 UTC 
Created attachment 330733 [details] [review]
check-accelerated: export renderer string also for llvmpipe

Since the renderer string is now used to display the graphics label in
gnome-control-center, we need to make sure it gets set even if software
rendering is in use, else we wind up showing an empty string to the
user.
Comment 2 Cosimo Cecchi 2016-07-01 17:15:38 UTC 
Review of attachment 330733 [details] [review]:

Thank you! Looks good.
Comment 3 Michael Catanzaro 2016-07-01 17:16:24 UTC 
Attachment 330733 [details] pushed as 51d1e18 - check-accelerated: export renderer string also for llvmpipe
Comment 4 Mario Sánchez Prada 2018-01-09 16:02:51 UTC 
While rebasing gnome-session for Endless, I found that we have a patch applied downstream that fixes a regression introduced by the patch from this bug, so reopening: https://github.com/endlessm/gnome-session/commit/268bb41ccdf8af24047bc7d0ab16aedcf46e07ed
Comment 5 Mario Sánchez Prada 2018-01-09 16:03:31 UTC 
Created attachment 366560 [details] [review]
tools: don't check software rendering before GLES helper

See the patch attached after rebasing it on top of the master branch
Comment 6 Ray Strode [halfline] 2018-01-09 19:12:12 UTC 
Review of attachment 366560 [details] [review]:

::: tools/gnome-session-check-accelerated.c
@@ +255,3 @@
+                        renderer_string = gl_renderer_string;
+                else if (gles_software_rendering)
+                        renderer_string = gles_software_rendering;

this should say gles_renderer_string i think.
Comment 7 Ray Strode [halfline] 2018-01-09 19:13:04 UTC 
(pushed with that change)
Attachment 366560 [details] pushed as 3bbd649 - tools: don't check software rendering before GLES helper
Comment 8 Mario Sánchez Prada 2018-01-09 20:35:56 UTC 
Well, that was quick. Thanks, Ray!