After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768268 - qtdemux: Push caps only when it was updated
qtdemux: Push caps only when it was updated
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-01 08:37 UTC by Seungha Yang
Modified: 2016-07-04 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Push caps only when it was updated (2.24 KB, patch)
2016-07-01 08:38 UTC, Seungha Yang 		none Details | Review
qtdemux: Push caps only when it was updated (1.92 KB, patch)
2016-07-01 09:29 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2016-07-01 08:37:18 UTC 
qtdemux: Push caps only when it was updated

Commit 7873bede3134b15e5066e8d14e54d1f5054d2063 caused new caps
event per moof without consideration of duplication.
Comment 1 Seungha Yang 2016-07-01 08:38:02 UTC 
Created attachment 330702 [details] [review]
qtdemux: Push caps only when it was updated
Comment 2 Sebastian Dröge (slomo) 2016-07-01 09:11:26 UTC 
Review of attachment 330702 [details] [review]:

::: gst/isomp4/qtdemux.c
@@ +7531,3 @@
     }
+
+    if (!prev_caps || !gst_caps_is_equal_fixed (prev_caps, stream->caps)) {

Wouldn't it be better to just get prev_caps here? Then you don't need to carry it around all the time and unref it in all return paths but just have it locally here
Comment 3 Seungha Yang 2016-07-01 09:29:41 UTC 
Created attachment 330706 [details] [review]
qtdemux: Push caps only when it was updated
Comment 4 Seungha Yang 2016-07-01 09:32:41 UTC 
Oops... Thanks for reviewing :) Please review the fixed patch.
Comment 5 Sebastian Dröge (slomo) 2016-07-01 09:37:38 UTC 
Attachment 330706 [details] pushed as 231018b - qtdemux: Push caps only when it was updated