GNOME Bugzilla – Bug 768039
qmmp player window trembles when dragged
Last modified: 2016-10-14 16:10:29 UTC
Created attachment 330368 [details] bug demonstration Watch the video please. This behavior does not happen under x11 session.
Created attachment 331492 [details] [review] wayland-surface: Make get_relative_coordinates() accurate for X apps Using clutter API to transform coordinates is only accurate right after a clutter layout pass but this function is used e.g. to deliver pointer motion events which can happen at any time. This isn't a problem for wayland clients since they don't control their position, but X clients do and we'd be sending outdated coordinates if a client is moving a window in response to motion events.
Review of attachment 331492 [details] [review]: Looks good to me.
Attachment 331492 [details] pushed as b281f95 - wayland-surface: Make get_relative_coordinates() accurate for X apps
This behavior is still happening under Wayland when I drag Audacious and qmmp player using touchscreen. No problem if I drag the players using touchpad or mouse.
How do you move qmmp using touch? I tried to move it, but it doesn't move at all. Either way, I suppose the issue would be solved by using meta_wayland_surface_get_relative_coordinates() in meta-wayland-touch.c.
Created attachment 336141 [details] [review] wayland/touch: Use surface relative coordinate helper Use the global to surface local coordinate converter helper, as that will currently convert coordinates for Xwayland client more correctly. --- I can't reproduce the issue (qmmp doesn't move when I touch-drag) so consider this patch untested. Side notes: We do these type of transformation in a few other places (drag-n-drop, tablets) will will have the same issues. When we start transforming Xwayland windows (assuming we succeed in doing that with a reasonable success rate) this solution will stop working.
(In reply to Jonas Ådahl from comment #5) > How do you move qmmp using touch? I tried to move it, but it doesn't move at > all. I touch title bar and move the main window. Here is a video recorded on Gnome 3.22 installed on Arch from gnome unstable repository. https://www.youtube.com/watch?v=8_if_lrwCrg&feature=youtu.be
Review of attachment 336141 [details] [review]: looks fine
Attachment 336141 [details] pushed as 0dfb5d3 - wayland/touch: Use surface relative coordinate helper