After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768029 - infinite loop in parse_name_internal()
infinite loop in parse_name_internal()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-06-25 11:58 UTC by Ernestas Kulik
Modified: 2016-06-25 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
stack trace (2.96 KB, text/plain)
2016-06-25 11:58 UTC, Ernestas Kulik 		  Details
proposed fix (1.31 KB, patch)
2016-06-25 12:00 UTC, Ernestas Kulik 		accepted-commit_now Details | Review

Description Ernestas Kulik 2016-06-25 11:58:56 UTC 
Created attachment 330355 [details]
stack trace

The latest commit[1] breaks Nautilus master.

parse_name_internal() enters an infinite loop if none of the closures in the hash table return a value.

The result is g_hash_table_iter_next() asserting non-stop.

[1] https://git.gnome.org/browse/glib/commit/?id=375b4ca65cf09789aeeb4e15ac3b12211729aa31
Comment 1 Ernestas Kulik 2016-06-25 12:00:06 UTC 
Created attachment 330356 [details] [review]
proposed fix
Comment 2 Colin Walters 2016-06-25 12:29:29 UTC 
Review of attachment 330356 [details] [review]:

LGTM, thanks.