After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768006 - flvdemux: Add support for H263 and MPEG4 part2
flvdemux: Add support for H263 and MPEG4 part2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-24 11:50 UTC by Vivia Nikolaidou
Modified: 2016-06-27 06:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-flvdemux-Add-support-for-H263-and-MPEG4-part2.patch (1.82 KB, patch)
2016-06-24 11:51 UTC, Vivia Nikolaidou 		committed Details | Review

Description Vivia Nikolaidou 2016-06-24 11:50:47 UTC 
Found while testing https://bugzilla.gnome.org/show_bug.cgi?id=768005
Comment 1 Vivia Nikolaidou 2016-06-24 11:51:23 UTC 
Created attachment 330310 [details] [review]
0001-flvdemux-Add-support-for-H263-and-MPEG4-part2.patch
Comment 2 Sebastian Dröge (slomo) 2016-06-24 12:05:54 UTC 
Review of attachment 330310 [details] [review]:

ffmpeg agrees
Comment 3 Sebastian Dröge (slomo) 2016-06-24 12:30:38 UTC 
commit 6ac02f8595292a4501644f17dd3d87a0d0582d7d
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Fri Jun 24 14:48:53 2016 +0300

    flvdemux: Add support for H263 and MPEG4 part2
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768006
Comment 4 Nicolas Dufresne (ndufresne) 2016-06-25 00:06:16 UTC 
How? The spec does not support these, only Sorenson H263, and no H264 ...
Comment 5 Nicolas Dufresne (ndufresne) 2016-06-25 00:10:26 UTC 
(mean no mpeg 4) Can we at least document in the code that this is not standard, seems bad habit to deviate from spec without mentioning ...
Comment 6 Sebastian Dröge (slomo) 2016-06-27 06:21:27 UTC 
commit d6f597db20e06e60e411c8f9cfdc4c9874b97826
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 27 09:20:35 2016 +0300

    flvdemux: Add comment about H263/MPEG4P2 being non-standard for FLV
    
    They are however supported by ffmpeg and apparently used out there.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768006