GNOME Bugzilla – Bug 768004
Allow changing font colours and sizes
Last modified: 2021-07-05 11:31:53 UTC
As available in iBooks: https://people.gnome.org/~hadess/gnome-books-examples/ibooks-ios/ https://people.gnome.org/~hadess/gnome-books-examples/ibooks-osx/
Created attachment 330641 [details] [review] epubview: font size and invert colors buttons I've added a new menu to control font options. In this menu I've added the font size buttons and another button to invert colors. The invert colors assume that the background is light and the text is dark and when it's inverted sets the background to black and the text to white. The menu is ugly now, if we can create some buttons or widgets in this menu, it will look a lot better.
This patch is a first version. I've some problems creating the menu, I wanted to add buttons and not close the menu on click but I don't know how. In any case I've uploaded this patch.
Review of attachment 330641 [details] [review]: Thank you, Daniel. I pushed your patch in a branch here, together with some further cleanups that streamline the UI to make it similar to the existing night mode of the Evince view: https://git.gnome.org/browse/gnome-documents/log/?h=wip/epub-colors The main issue remaining is that the invert colors function should probably not hardcode black and white like that, and does not really seem to work reliably. I tried playing a little bit with the filter: invert CSS function and it seems to help somewhat, but I couldn't find a convincing combination yet. Help welcome, feel free to push to the branch :)
Wouldn't it be better if this functionality was hidden inside the view provided by libgepub?
Definitely, but until we have a good implementation it doesn't really matter, and I'm fine keeping it in the Documents JS code as it makes it easier to hack.
Ping. Anybody interested in moving this forward?
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-documents/-/issues/ Thank you for your understanding and your help.