After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767997 - wayland: mutter tries to focus override-redirect X11 windows with focus-follow-mouse
wayland: mutter tries to focus override-redirect X11 windows with focus-follo...
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-24 09:13 UTC by Olivier Fourdan
Modified: 2016-07-06 07:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] window: Do not try to focus O-R windows in focus-follow-mouse (776 bytes, patch)
2016-06-24 09:29 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2016-06-24 09:13:55 UTC 
Description:

Under Wayland, running an X11/Xwayland client, mutter tries to focus override-redirect windows in focus-follow-mouse, thus causing a critical warning.

Steps to reproduce:

1. Log-in "GNOME on Wayland" session
2. Enable focus-follow-mouse in gnome-tweak-tool
3. Open Firefox (which runs on X11/Xwayland)
4. Open a menu in Firefox and move the pointer within that menu 

Actual result:

(gnome-shell:27376): mutter-CRITICAL **: meta_window_focus: assertion '!window->override_redirect' failed

Expected results:

No warning

Additional data:

(gdb) break meta_window_focus
Breakpoint 1 at 0x7f129fd09f30: file core/window.c, line 4265.
(gdb) cont
Continuing.

Thread 1 "gnome-shell" hit Breakpoint 1, meta_window_focus (window=0x34b3bc0, timestamp=88386225)
    at core/window.c:4265
4265	  g_return_if_fail (!window->override_redirect);
(gdb) bt

+ Trace 236386

  • #0 meta_window_focus
    at core/window.c line 4265
  • #1 mouse_mode_focus
    at core/window.c line 7510
  • #2 window_focus_on_pointer_rest_callback
    at core/window.c line 7618
  • #3 g_timeout_dispatch
    at gmain.c line 4588
  • #4 g_main_dispatch
    at gmain.c line 3165
  • #5 g_main_context_dispatch
    at gmain.c line 3780
  • #6 g_main_context_iterate
    at gmain.c line 3851
  • #7 g_main_loop_run
    at gmain.c line 4045
  • #8 meta_run
    at core/main.c line 537
  • #9 main
    at main.c line 471 
$1 = 1

Patch to follow shortly...
Comment 1 Olivier Fourdan 2016-06-24 09:29:50 UTC 
Created attachment 330305 [details] [review]
[PATCH] window: Do not try to focus O-R windows in focus-follow-mouse

Doing so would raise a critical warning.
Comment 2 Rui Matos 2016-07-05 18:21:23 UTC 
Review of attachment 330305 [details] [review]:

ok
Comment 3 Olivier Fourdan 2016-07-06 07:21:16 UTC 
Comment on attachment 330305 [details] [review]
[PATCH] window: Do not try to focus O-R windows in focus-follow-mouse

attachment 330305 [details] [review] pushed to master as commit 492854e - window: Do not try to focus O-R windows in focus-follow-mouse