GNOME Bugzilla – Bug 767918
Request periodic scans while WiFi list is open
Last modified: 2018-02-21 12:06:55 UTC
NM upstream would like to reduce periodic scanning, and that means that clients should start implementing scan requests themselves while their wifi lists are open if they use that model. Similar to how the Windows and macOS WiFi lists update themselves when they are open. Once enough clients have been updated (eg, nm-applet, gnome-shell, KDE, geoclue, etc) we can reduce periodic scanning in NM itself.
Created attachment 330148 [details] [review] 0001-network-request-periodic-scans-while-the-WiFi-list-i.patch
A further enhancement would be to show a spinner or something while the scan is happening, but NM doesn't yet expose a "now scanning" property for wifi devices.
Should we mark bug 732651 as a duplicate?
Review of attachment 330148 [details] [review]: ::: js/ui/status/network.js @@ +795,3 @@ + _onScanTimeout: function() { + this._requestAndScheduleScan(); + return GLib.SOURCE_REMOVE; Not sure this or this._device.request_scan_simple(null); return GLib.SOURCE_CONTINUE; is more obvious ...
*** Bug 732651 has been marked as a duplicate of this bug. ***
Created attachment 330450 [details] [review] 0001-network-request-periodic-scans-while-the-WiFi-list-i.patch Ok, how about this then?
Review of attachment 330450 [details] [review]: LGTM
*** Bug 771332 has been marked as a duplicate of this bug. ***
(In reply to Dan Williams from comment #0) > Once enough clients have been updated (eg, nm-applet, gnome-shell, KDE, > geoclue, etc) we can reduce periodic scanning in NM itself. Did you file a bug for gnome-control-center or should I?
(In reply to Michael Catanzaro from comment #9) > (In reply to Dan Williams from comment #0) > > Once enough clients have been updated (eg, nm-applet, gnome-shell, KDE, > > geoclue, etc) we can reduce periodic scanning in NM itself. > > Did you file a bug for gnome-control-center or should I? In the end nobody did, and we only recently found it we should have been doing this. Bug was filed as: https://bugzilla.gnome.org/show_bug.cgi?id=793647 In which version of NetworkManager was the change implemented?
(In reply to Bastien Nocera from comment #10) > In which version of NetworkManager was the change implemented? Answering my own question, it was implemented in NetworkManager 1.10: * Background scanning is now disabled for non-WPA-Enterprise Wi-Fi networks.