After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767616 - Fix "format not a string literal" warnings
Fix "format not a string literal" warnings
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-13 17:16 UTC by Bastien Nocera
Modified: 2016-06-14 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix "format not a string literal" warnings (2.51 KB, patch)
2016-06-13 17:16 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2016-06-13 17:16:19 UTC
.
Comment 1 Bastien Nocera 2016-06-13 17:16:24 UTC
Created attachment 329712 [details] [review]
Fix "format not a string literal" warnings

With new GCC6.
Comment 2 Carlos Soriano 2016-06-14 07:43:47 UTC
Review of attachment 329712 [details] [review]:

The alternative is to change some of this code to have the format string directly in the prints calls right?

Either way, looks good, and refactoring part of this code could be a good newcomer task.
Comment 3 Bastien Nocera 2016-06-14 08:19:20 UTC
Attachment 329712 [details] pushed as adac074 - Fix "format not a string literal" warnings