GNOME Bugzilla – Bug 767614
VPN bug fixes
Last modified: 2016-06-24 15:27:01 UTC
Fallout from libnm 1.2 port
Created attachment 329708 [details] [review] network: Fix crash creating a VPN The listing of VPN plugins was done using the nm-glib API instead of the new libnm 1.2 one.
Created attachment 329709 [details] [review] network: Remove the first page of the "Add Connection" wizard We still offered to add Bond, Team, Bridge and VLAN connections even though we don't support them any more. Remove the first page as we only offer to add VPN connections.
Created attachment 329710 [details] [review] network: Fix VPN UI not showing up The VPN editor API changed as well.
Review of attachment 329708 [details] [review]: LGTM
Review of attachment 329709 [details] [review]: There's only one element in the connection_types struct now, so couldn't that just be removed?
Review of attachment 329710 [details] [review]: LGTM
Created attachment 329724 [details] [review] network: Remove the first page of the "Add Connection" wizard We still offered to add Bond, Team, Bridge and VLAN connections even though we don't support them any more. Remove the first page as we only offer to add VPN connections.
Created attachment 329725 [details] [review] network: Simplify complete_connection_for_type() Now that there's only one type to be added (VPNs).
Review of attachment 329709 [details] [review]: I've done that in a separate commit. Also removed an unused variable in the new version of the patch.
Attachment 329708 [details] pushed as 2a7b192 - network: Fix crash creating a VPN Attachment 329710 [details] pushed as 7adfaf1 - network: Fix VPN UI not showing up Attachment 329724 [details] pushed as d0fcd58 - network: Remove the first page of the "Add Connection" wizard Attachment 329725 [details] pushed as c6f1b3a - network: Simplify complete_connection_for_type()