After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767578 - Qt-GStreamer not compiling with Clang 3.8
Qt-GStreamer not compiling with Clang 3.8
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: qt-gstreamer
unspecified
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-12 21:57 UTC by Aleix Pol
Modified: 2016-06-13 09:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (3.38 KB, patch)
2016-06-12 21:57 UTC, Aleix Pol
none Details | Review
formatted patch (3.30 KB, patch)
2016-06-13 08:46 UTC, Aleix Pol
committed Details | Review

Description Aleix Pol 2016-06-12 21:57:30 UTC
Created attachment 329650 [details] [review]
fix

That's the error messages:
/home/apol/devel/frameworks/qt-gstreamer/elements/gstqtvideosink/gstqtquick2videosink.cpp:251:51: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
    GST_TRACE_OBJECT(self, "Posting new buffer (%"GST_PTR_FORMAT") for rendering.", buffer);

Patch attached.
Comment 1 Tim-Philipp Müller 2016-06-13 08:34:05 UTC
And how does the CMakeLists.txt change relate to this? It looks like it's for another issue.

Could you provide a patch in git format-patch format please?
Comment 2 Aleix Pol 2016-06-13 08:46:17 UTC
Created attachment 329668 [details] [review]
formatted patch

The cmake change is indeed unrelated.
Comment 3 Tim-Philipp Müller 2016-06-13 09:03:10 UTC
Thanks a lot, pushed:

commit fc159e5c4c8ffeabdc7319514c6bb19c9c9e1d3b
Author: Aleix Pol <aleixpol@kde.org>
Date:   Mon Jun 13 10:36:34 2016 +0200

    Fix build with Clang 3.8
    
    error: invalid suffix on literal; C++11 requires a space between literal and identifier
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767578


If the cmake thing is something that needs fixing upstream as well, please file another bug or re-open this one, thanks!