After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767514 - House all j2k plugins in a single project
House all j2k plugins in a single project
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: dont know
git master
Other Windows
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-10 20:43 UTC by Aaron Boxer
Modified: 2016-06-11 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Aaron Boxer 2016-06-10 20:43:39 UTC
There is currently a fair bit of redundancy between the various j2k plugins:
rtp payloader/depayloader, openjpeg encoder/decoder, jpeg2000parse, decimator.

Moving them all to a single project would allow us to streamline the code.
Comment 1 Tim-Philipp Müller 2016-06-10 21:20:02 UTC
Unlikely to happen to the extent that I think I'm going to close this, sorry :)

You can move useful bits of code into -bad/gst-libs/gst/codecparser/ and make -bad plugins use that (ie. not the rtp (de)payloader) and hope one day we'll move codecparsers into -base or something.
Comment 2 Sebastian Dröge (slomo) 2016-06-10 22:06:24 UTC
Also parts of the duplication can be solved by moving helper functions to libgstpbutils, like the existing codec specific things in codecutils.[ch].

What kind of duplication are you thinking of, what kind of API would it get?
Comment 3 Aaron Boxer 2016-06-11 02:10:18 UTC
I would like all information about j2k markers and boxes to be in one single header file, for example.

Also, yes, helper functions could be centralized.

Someone could review all j2k related plugins, find common structs,enums, helper functions, and move them to one place.
Comment 4 Sebastian Dröge (slomo) 2016-06-11 08:59:38 UTC
We can worry about that once it becomes an issue :) Ideally the jpeg2000 parsing should be in libgstcodecparsers together with the others, and at some point in the future we move that library to gst-plugins-base and have it used everywhere. And until then use (private!) copies of that in the other modules that are kept up to date.
Comment 5 Aaron Boxer 2016-06-11 12:14:54 UTC
Alrighty :)