After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767506 - audiovisualizer: still uses old GST_BUFFER_TIMESTAMP() macro switch it to GST_BUFFER_PTS()
audiovisualizer: still uses old GST_BUFFER_TIMESTAMP() macro switch it to GST...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-10 18:08 UTC by Thomas Jones
Modified: 2016-06-11 08:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (980 bytes, patch)
2016-06-10 18:08 UTC, Thomas Jones 		committed Details | Review
Fixed patch (2.40 KB, patch)
2016-06-11 02:21 UTC, Thomas Jones 		none Details | Review

Description Thomas Jones 2016-06-10 18:08:31 UTC 
Created attachment 329582 [details] [review]
fix

As the title says.

I can't even find where GST_BUFFER_TIMESTAMP() is defined now because it's not in the header with the rest of the GST_BUFFER_* macros so just setting pts might not do the same thing, however in this case it seems to me to be the right thing.
Comment 1 Nicolas Dufresne (ndufresne) 2016-06-10 18:25:38 UTC 
For the reference, it's in gstcompat.h:

#define GST_BUFFER_TIMESTAMP          GST_BUFFER_PTS
#define GST_BUFFER_TIMESTAMP_IS_VALID GST_BUFFER_PTS_IS_VALID
Comment 2 Thomas Jones 2016-06-11 02:21:32 UTC 
Created attachment 329599 [details] [review]
Fixed patch

OK, This one should work
Comment 3 Thomas Jones 2016-06-11 02:22:00 UTC 
Whoops wrong bug
Comment 4 Sebastian Dröge (slomo) 2016-06-11 08:48:10 UTC 
commit 247ce9f39f6437366ad95f4ac2a018f16e181bac
Author: Thomas Jones <thomas.jones@utoronto.ca>
Date:   Fri Jun 10 14:04:36 2016 -0400

    audiovisualizer: Use GST_BUFFER_PTS() instead of GST_BUFFER_TIMESTAMP()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767506