After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767495 - "Done" button remains greyed out when changing time by typing in text fields (as opposed to + - buttons)
"Done" button remains greyed out when changing time by typing in text fields ...
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: alarms
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-10 11:58 UTC by Azari
Modified: 2016-10-09 08:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
alarm: allow SetupDialog response when changing time in the entries (2.21 KB, patch)
2016-06-10 12:15 UTC, Felipe Borges 		none Details | Review

Description Azari 2016-06-10 11:58:54 UTC 
When trying to change the time in an alarm by typing in the text fields instead of using the + - buttons, the 'Done' button remains greyed out until you focus a different text field. Hitting enter works though.
Comment 1 Felipe Borges 2016-06-10 12:15:15 UTC 
Created attachment 329569 [details] [review]
alarm: allow SetupDialog response when changing time in the entries
Comment 2 Paolo Borelli 2016-06-12 14:29:24 UTC 
Review of attachment 329569 [details] [review]:

Does using changed still enforce the validation we do on the text that gets entered? E.g. will it prevent you from having 61 minutes? In other words, does this run after the "ouput" signal handler?


Also, this seems to me a gtk bug... editing the text should trigger value-changed
Comment 3 Paolo Borelli 2016-10-09 08:00:18 UTC 
I verified that the output signal handler still runs. Patch applied, sorry for the delay.