GNOME Bugzilla – Bug 767447
Cannot go back to a place through seach after panning
Last modified: 2018-03-26 13:51:52 UTC
Created attachment 329454 [details] Before Suppose I have arrived at a place after searching it in placeEntry, now I pan from that place to the neighbourhood. Now I search the same place again so that I can go back to my original place, but it won't take me there.
Created attachment 329455 [details] [review] placeEntry: avoid checking current place with place to go In case of panning the local place won't change and if we want to go back to the initial place we can't. This patch allow going back to the initial place.
Created attachment 329456 [details] After
Mattias/Jonas, Am I missing something in the patch? I am not aware of the reason why the statement was present there in the first place.
Review of attachment 329455 [details] [review]: I think it looks good. However, I think I'd like some second opinion, as I'm a bit scared of undesired side-effects I might have overlooked, such as maybe the recent visited place store.
Review of attachment 329455 [details] [review]: Thanks! LGTM, and I also tested it. Doesn't seem to give any undesired side-effects AFAICS.
Unfortunatly, after some additional testing I discovered some weird effects of this. Search for some transit trips, select one, and you're bounced back to the result list. So, I reverted this for now.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/67.