GNOME Bugzilla – Bug 767438
text not visible when there's an inline image
Last modified: 2016-07-06 07:39:08 UTC
Created attachment 329448 [details] screenshot of message view before and after replying I attach a screenshot of what I see before and after replying and the source of the message received. As you can see, only the inline image is visible; when I reply the text appears, while the image disappears (but this is issue #710356). For the records, I can see a previous similar issue marked as fixed, issue #713846.
Created attachment 329449 [details] message source showing embedded inline image
Okay, so I think what is happening here is that when Geary.RFC822.Message::construct_body_from_mime_parts is looking to build a message body to display, during the first pass that looks for HTML content the plain text part is ignored but the inline image gets converted to a HTML IMG element and returned as the body. This makes it look like an HTML part was found, and hence the second pass looking for plain text never starts and so text part is never found. So we probably want to ignore inlined parts when determining if a pass found some body content, but we also want to be able to handle messages with inline-parts-only, so maybe three passes are needed - HTML, plain text, and inline only?
Fix commited to master as 5354ccb, will cherry-pick to 0.11 if no one complains about it over the next few days. Federico, if you're running master, can you verify this fixes the issue for you? Ta!
Yes, it's fixed. Thanks!
Great! I've also merged this to the geary-0.11 branch, so will be in the next release.
Followup fix for critical warning when there is neither a HTML or plain text body part pushed to master as cc8b79b and geary-0.11 as 384d158.