After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767300 - v4l2object uses deprecated RGB15 V4L2 format code
v4l2object uses deprecated RGB15 V4L2 format code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.1
Other Linux
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-06 18:03 UTC by Kieran Bingham
Modified: 2016-06-07 21:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-v4l2object-Use-non-deprecated-V4L2-type-for-RGB15.patch (1.11 KB, patch)
2016-06-06 18:03 UTC, Kieran Bingham 		none Details | Review
0001-v4l2object-Use-non-deprecated-V4L2-type-for-RGB15.patch - Using fourcc_nc (1.09 KB, patch)
2016-06-06 19:29 UTC, Kieran Bingham 		committed Details | Review

Description Kieran Bingham 2016-06-06 18:03:49 UTC 
Created attachment 329215 [details] [review]
0001-v4l2object-Use-non-deprecated-V4L2-type-for-RGB15.patch

v4l2object, now supports the V4L2_PIX_FMT_XRGB555 RGB pixel format, but does so by mapping to the old deprecated format.

Enumerations with drivers supporting V4L2_PIX_FMT_XRGB555 will list RGB15, however when used in a pipeline, this format gets set as the deprecated V4L2_PIX_FMT_RGB555, and fails to map buffers.

Patch attached to update to the new V4L2 pixel format code.
Comment 1 Nicolas Dufresne (ndufresne) 2016-06-06 18:41:37 UTC 
Review of attachment 329215 [details] [review]:

::: sys/v4l2/gstv4l2object.c
@@ +1661,3 @@
         break;
       case GST_VIDEO_FORMAT_RGB15:
+        fourcc = V4L2_PIX_FMT_XRGB555;

Unfortunatly this is not backward compatible. We'll need a fallback here. We can probably reuse the fallback for multi-planer.
Comment 2 Kieran Bingham 2016-06-06 19:29:28 UTC 
Created attachment 329229 [details] [review]
0001-v4l2object-Use-non-deprecated-V4L2-type-for-RGB15.patch - Using fourcc_nc

Patch updated, as it looks like the other formats affected by this same issue simply put the non-deprecated format as the fourcc_nc which enables Gstreamer to select that preferentially.
Comment 3 Nicolas Dufresne (ndufresne) 2016-06-06 21:16:24 UTC 
Review of attachment 329229 [details] [review]:

Thanks. For future submission, please remove the Signed-off-by in the comment, we trust the author line in this project.
Comment 4 Nicolas Dufresne (ndufresne) 2016-06-06 21:21:55 UTC 
Pushed as b4e6a71
Comment 5 Nicolas Dufresne (ndufresne) 2016-06-06 21:22:40 UTC 
Should go in 1.8 branch too.
Comment 6 Nicolas Dufresne (ndufresne) 2016-06-07 21:18:06 UTC 
Branch: 1.8
Commit: 586a10da96086031c83ef9f57372839cd336ba89