After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767254 - build failure in flatpak apps for gtksourceview
build failure in flatpak apps for gtksourceview
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-04 19:43 UTC by Matthias Clasen
Modified: 2016-06-10 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matthias Clasen 2016-06-04 19:43:26 UTC 
I'm seeing a couple of apps fail to build in flatpak, with:

gtksourcecompletionwords.c: In function ‘gtk_source_completion_words_populate’:
gtksourcecompletionwords.c:239:32: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
       g_utf8_strlen (word, -1) < words->priv->minimum_word_size))
                                ^
cc1: all warnings being treated as errors

See eg

https://gnome7.codethink.co.uk//logs/build-2016-06-04-200001/build-org.gnome.Calculator.txt
Comment 1 Sébastien Wilmet 2016-06-05 09:27:39 UTC 
On Fedora 24 (x86_64) I have no warnings or errors.

With commit b20d9b6358d339d9a3d29de31f8a13a706ce7e73 the problem at gtksourcecompletionwords.c should be fixed (it's also backported on 3.20), but there are maybe other places in GtkSourceView where a glong is compared to a guint. So it would be better to find a way to reproduce the error.
Comment 2 Sébastien Wilmet 2016-06-05 09:40:23 UTC 
Maybe the warning appears on platforms where sizeof(glong) == sizeof(guint). Because when sizeof(glong) > sizeof(guint) the comparison is fine.

Is the error triggered on ARM?

On my machine:
sizeof (guint) = 4
sizeof (glong) = 8
Comment 3 Matthias Clasen 2016-06-06 02:56:00 UTC 
yes, its an arm build.
Comment 4 Sébastien Wilmet 2016-06-10 11:18:19 UTC 
This one is fixed.