After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767239 - Tautological comparisons in convert tests
Tautological comparisons in convert tests
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-06-04 13:18 UTC by Krzesimir Nowak
Modified: 2017-11-03 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes some tautological comparisons in convert tests. (1.80 KB, patch)
2016-06-04 13:18 UTC, Krzesimir Nowak 		committed Details | Review

Description Krzesimir Nowak 2016-06-04 13:18:28 UTC 
Created attachment 329121 [details] [review]
Fixes some tautological comparisons in convert tests.

Looking at the other parts of the code we usually compare items_written2 to items_written, not to self.
Comment 1 Philip Withnall 2017-11-03 16:54:33 UTC 
Review of attachment 329121 [details] [review]:

An obvious win.