After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767063 - Fix build of libxml2 2.9.4 (git master) on pre-C99 compilers
Fix build of libxml2 2.9.4 (git master) on pre-C99 compilers
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
: 766798 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-05-31 12:58 UTC by Fan, Chun-wei
Modified: 2017-06-13 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the sources for C89 compilers (1.62 KB, patch)
2016-05-31 13:08 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2016-05-31 12:58:23 UTC 
Hi,

A rather recent commit (502f6a6) fixed a vulnerability, but unfortunately broke the build on pre-C99 compilers due to declarations in the middle of the block.  I will attach patches to fix those issues in the code.

With blessings, thank you!
Comment 1 Fan, Chun-wei 2016-05-31 13:08:16 UTC 
Created attachment 328801 [details] [review]
Fix the sources for C89 compilers

Hi,

Here comes the patch.

With blessings, thank you!
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-06-22 07:36:41 UTC 
Review of attachment 328801 [details] [review]:

It is simple enough and looks good to me. Go ahead.
Comment 3 Fan, Chun-wei 2016-06-23 11:04:18 UTC 
Hi Nacho,

Thanks, I have pushed the patch as d77e5fc.

With blessings, thank you!
Comment 4 Nick Wellnhofer 2017-06-13 16:25:53 UTC 
*** Bug 766798 has been marked as a duplicate of this bug. ***