After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767042 - Make Flagged and rating labels part of their corresponding buttons
Make Flagged and rating labels part of their corresponding buttons
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
0.23.x
Other Linux
: Normal enhancement
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-30 22:10 UTC by akronix5
Modified: 2016-06-19 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot with the patch applied (372.05 KB, image/png)
2016-05-30 22:10 UTC, akronix5 		  Details
Tentative patch (5.49 KB, patch)
2016-05-30 22:14 UTC, akronix5 		committed Details | Review

Description akronix5 2016-05-30 22:10:21 UTC 
Created attachment 328766 [details]
Screenshot with the patch applied

Hi!

I think that I'd be a very nice idea to have the labels: "Flagged" and "Rating", inside of the buttons for their respective action. I find it clearer and easier to use.
Also, It partially solves the problem I've found in ApricityOS that there's no any icon displaying (there's an empty space instead) for the Rating filter button. Using also the label as button allows to still be able to use the functionality, even though the icon had been problems to be displayed.

I've done a tentative patch to solve this. I attach it along to a snapshot of how it's looking applied on my computer.
Comment 1 akronix5 2016-05-30 22:14:13 UTC 
Created attachment 328767 [details] [review]
Tentative patch
Comment 2 akronix5 2016-06-08 22:38:31 UTC 
Is somebody interested on this?.... or I wasted my time :/
Comment 3 Kevin McBride 2016-06-09 00:36:48 UTC 
I tested the patch using GIT and verified that the patch works.  Somehow, I could not execute a pull request, but a shotwell developer should be able to review and upload the patch soon.
Comment 4 Jens Georg 2016-06-09 06:35:54 UTC 
(In reply to akronix5 from comment #2)
> Is somebody interested on this?.... or I wasted my time :/

Sorry, I'm somewhat busy currently.
Comment 5 Jens Georg 2016-06-16 20:16:30 UTC 
Review of attachment 328767 [details] [review]:

+1