After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766945 - Ctrl+D not shown in keyboard shortcuts list
Ctrl+D not shown in keyboard shortcuts list
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-27 16:55 UTC by Raunaq
Modified: 2016-12-26 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 766945 - Ctrl+D not shown in keyboard shortcuts list (1.16 KB, patch)
2016-05-27 16:57 UTC, Raunaq 		none Details | Review
Bug 766945 - Ctrl+D not shown in keyboard shortcuts list (1.31 KB, patch)
2016-05-28 04:36 UTC, Raunaq 		none Details | Review

Description Raunaq 2016-05-27 16:55:03 UTC 
Ctrl + D is used to delete a line. Add that to keyboard shortcut list
Comment 1 Raunaq 2016-05-27 16:57:41 UTC 
Created attachment 328647 [details] [review]
Bug 766945 - Ctrl+D not shown in keyboard shortcuts list

Added ctrl+d in shortcuts list.
Comment 2 Christian Hergert 2016-05-27 19:29:25 UTC 
Review of attachment 328647 [details] [review]:

::: data/ui/ide-shortcuts-window.ui
@@ -279,2 +279,5 @@
               </object>
             </child>
+            <child>
+              <object class="GtkShortcutsShortcut">
+                <property name="visible">1</property>

use true instead of 1
Comment 3 Raunaq 2016-05-28 04:36:05 UTC 
Created attachment 328655 [details] [review]
Bug 766945 - Ctrl+D not shown in keyboard shortcuts list

Added ctrl+d in shortcuts list.

https://bugzilla.gnome.org/show_bug.cgi?id=766945

Bug 766945 - Ctrl+D not shown in keyboard shortcuts list

Used "true" instead of "1" for visibility.
Comment 4 Raunaq 2016-05-28 05:31:31 UTC 
(In reply to Christian Hergert from comment #2)
> Review of attachment 328647 [details] [review] [review]:
> 
> ::: data/ui/ide-shortcuts-window.ui
> @@ -279,2 +279,5 @@
>                </object>
>              </child>
> +            <child>
> +              <object class="GtkShortcutsShortcut">
> +                <property name="visible">1</property>
> 
> use true instead of 1

Hello! Its 1 for all child objects. Should i change it for them too? And any specific reason for using true instead of 1?
Comment 5 sébastien lafargue 2016-12-26 17:32:19 UTC 
changed to true and pushed, thanks