After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766891 - h265parse: codec_data cap field could be mis-populated when vps/sps/pps id's are not used contiguously from zero.
h265parse: codec_data cap field could be mis-populated when vps/sps/pps id's ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-26 00:02 UTC by Scott D Phillips
Modified: 2016-05-30 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
h265parse: Don't assume contiguous id's in make_codec_data (1.78 KB, patch)
2016-05-26 00:04 UTC, Scott D Phillips
committed Details | Review

Description Scott D Phillips 2016-05-26 00:02:26 UTC
The make_codec_data code assumes param set ids appear in the video stream contiguously from zero. That's not required to be the case, and invalid codec_data will be generated.
Comment 1 Scott D Phillips 2016-05-26 00:04:17 UTC
Created attachment 328538 [details] [review]
h265parse: Don't assume contiguous id's in make_codec_data
Comment 2 Sebastian Dröge (slomo) 2016-05-26 06:00:44 UTC
Comment on attachment 328538 [details] [review]
h265parse: Don't assume contiguous id's in make_codec_data

For the record, this is already fixed in h264parse since years it seems.
Comment 3 sreerenj 2016-05-26 09:01:17 UTC
Scott, Thanks for the patch. Could you please share a video sample too?
I just wanna keep a sample like this for my own test cases.
Comment 4 Scott D Phillips 2016-05-26 17:04:39 UTC
(In reply to sreerenj from comment #3)
> Scott, Thanks for the patch. Could you please share a video sample too?
> I just wanna keep a sample like this for my own test cases.

I found this problem with a licensed conformance testing stream. I can mail it to you.
Comment 5 sreerenj 2016-05-30 07:37:20 UTC
Sebastian, are you gonna push this?? Or I can push later today..
Comment 6 Sebastian Dröge (slomo) 2016-05-30 09:42:50 UTC
Attachment 328538 [details] pushed as 3edd641 - h265parse: Don't assume contiguous id's in make_codec_data