After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766666 - patch: make git-update.sh build with all cores available
patch: make git-update.sh build with all cores available
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-19 14:54 UTC by Danilo Cesar
Modified: 2016-05-20 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.29 KB, patch)
2016-05-19 14:54 UTC, Danilo Cesar 		none Details | Review
patch v2 (1.28 KB, patch)
2016-05-20 10:14 UTC, Danilo Cesar 		committed Details | Review

Description Danilo Cesar 2016-05-19 14:54:35 UTC 
Created attachment 328206 [details] [review]
Patch

Making git-update.sh builds with all cores available. In case of
failure it defaults to -j1.

Using this approach the developer can still override this by setting -j to something else in MAKEFLAGS, as stated by 299605dfe2f97fca330161ff01a392e1a85fe422.
Comment 1 Tim-Philipp Müller 2016-05-19 23:24:20 UTC 
Comment on attachment 328206 [details] [review]
Patch

>+    MAKEFLAGS="-j$CPUCORES $MAKEFLAGS" make $CPUCORES > "$tmp/$1-make.log" 2>&1

why the

  make $CPUCORES

part?
Comment 2 Danilo Cesar 2016-05-20 10:12:39 UTC 
(In reply to Tim-Philipp Müller from comment #1)
> Comment on attachment 328206 [details] [review] [review]
> Patch
> 
> >+    MAKEFLAGS="-j$CPUCORES $MAKEFLAGS" make $CPUCORES > "$tmp/$1-make.log" 2>&1
> 
> why the
> 
>   make $CPUCORES
> 
> part?

Because I'm stupid and naive to make a change in a patch before sending it because, you know, "it's too simple". =/

Sending a corrected patch in a few minutes...
Comment 3 Danilo Cesar 2016-05-20 10:14:04 UTC 
Created attachment 328248 [details] [review]
patch v2

Changset:
 - Remove the remaining $CPUCORES after the 'make' call.
Comment 4 Tim-Philipp Müller 2016-05-20 10:58:05 UTC 
Thanks!

commit 603b8188bb32fc7ef296615f2322467bca382a9a
Author: Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>
Date:   Thu May 19 11:27:36 2016 -0300

    scripts: make git-update.sh build with all cores available
    
    The git-update.sh now builds with all cores available. In case of
    failure it defaults to 1
    
    The developer can still override this by setting -j to something else
    in MAKEFLAGS, as stated by 299605dfe2f97fca330161ff01a392e1a85fe422.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766666
t