I think the debug log at 2300 line suitable than adding another else. If you think it should have higher log level, how would you like to change that GST_DEBUG to GST_WARNING starting with "return parameters" with fixed message

Comment on attachment 328162 [details] [review]
ahc: add error logging statement

Also please put {} around that :)

My other patch in https://bugzilla.gnome.org/show_bug.cgi?id=766638 makes this bug moot, as it adds error logging in a better way. I will close this bug.

PS - I'm happy to add braces in general (I actually prefer that way), but I was under the impression that gstreamer coding style omitted braces on if and else statements that contain only one line in the body. Am I mistaken?

We do

  if (..)
    ...
  else
    ...

or

  if (..) {
    ...
  } else {
    ...
  }

but never

  if (..) {
    ...
  } else
    ...

or

  if (..)
    ...
  else {
    ...
  }

:)

Got it, thanks for the clarification.

I just personally think the last two are very ugly and unbalanced :) But we have code like that

Heh, I happen to agree. I actually wrote it out with the brace and then removed it in order to comply my false perception of the coding standard.