After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766553 - The color plugin creates devices for fake VNC devices
The color plugin creates devices for fake VNC devices
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: color
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-17 09:19 UTC by Richard Hughes
Modified: 2016-05-17 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.08 KB, patch)
2016-05-17 09:22 UTC, Richard Hughes 		committed Details | Review

Description Richard Hughes 2016-05-17 09:19:40 UTC 
This causes an authentication prompt when the VNC session is not active, but regardless of that, color managed VNC fake devices do not make any sense.
Comment 1 Richard Hughes 2016-05-17 09:22:10 UTC 
Created attachment 328046 [details] [review]
fix
Comment 2 Bastien Nocera 2016-05-17 11:34:32 UTC 
Review of attachment 328046 [details] [review]:

::: plugins/color/gsd-color-state.c
@@ +982,3 @@
+        /* VNC creates a fake device that cannot be color managed */
+        if (g_str_has_prefix (gnome_rr_output_get_name (output), "VNC-")) {
+                g_debug ("ignoring as fake VNC device detected");

A couple of things:
- show the output name in the debug
- ensure that the output name is non-NULL

Looks fine otherwise. Have you tested this?
Comment 3 Richard Hughes 2016-05-17 13:25:41 UTC 
(In reply to Bastien Nocera from comment #2)
> A couple of things:
> - show the output name in the debug

Done.

> - ensure that the output name is non-NULL

Done, good catch.

> Looks fine otherwise. Have you tested this?

In Fedora yes, in RHEL soon.