After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766523 - uri-clip: make uri parameter of ges_uri_clip_new () const
uri-clip: make uri parameter of ges_uri_clip_new () const
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-16 15:46 UTC by Aurélien Zanelli
Modified: 2016-05-16 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
uri-clip: make uri parameter of ges_uri_clip_new () const (1.43 KB, patch)
2016-05-16 15:47 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2016-05-16 15:46:30 UTC 
ges_uri_clip_new function currently takes a non const string but it only give it to another function taking a const string parameter So I propose to make it constant to avoid compiler warning when having const string.
Comment 1 Aurélien Zanelli 2016-05-16 15:47:09 UTC 
Created attachment 327989 [details] [review]
uri-clip: make uri parameter of ges_uri_clip_new () const
Comment 2 Thibault Saunier 2016-05-16 16:21:32 UTC 
Review of attachment 327989 [details] [review]:

Hrm, that is a API change, I guess it is OK but I would like someone else to confirm
Comment 3 Tim-Philipp Müller 2016-05-16 16:27:40 UTC 
Don't think it's a problem. You're not changing the semantics really, just clarifying it. And it's fine to pass a gchar * as a const gchar * argument.
Comment 4 Thibault Saunier 2016-05-16 18:47:55 UTC 
Attachment 327989 [details] pushed as dc16ee6 - uri-clip: make uri parameter of ges_uri_clip_new () const