GNOME Bugzilla – Bug 766426
[review] lr/nmcli-overview-bgo766426: provide a quick overview of devices & their status and configuration
Last modified: 2016-07-19 12:32:27 UTC
This was often reqeuested in the user survery. The "nmcli" without argument should probably output something that could act like a better "ifconfig" (w/o arguments).
Ready for review. 53dae70 cli/connections: split out ac_state_to_color() bcb4049 cli/devices: export device_state_to_color() c4c9755 cli: output a short summary of devices when called without arguments https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=lr/nmcli-overview-bgo766426
I have lots of routes, thus outputting the routes is too verbose for my usecase. Maybe omit that? Otherwise, lgtm (great improvement!).
Branch LGTM. Only minor consideration on the output: bond0: unmanaged bond 3.7.1, B2:E4:F1:49:D4:0C, unmanaged, sw, fw 2, mtu 1500 Can we remove the second 'unmanaged'? Also, I find that the driver-version and the firmware-version don't add useful information for users. Personally I would drop them; but keep the routes :) I would also surround the description with double quotes or something like that to make explicit that it's a free form field, but I guess it's a matter of taste, feel free to ignore it. enp0s25: connected to enp0s25-static "Intel Ethernet Connection I217-LM" ethernet (e1000e), 54:EE:75:45:5A:53, hw, fw 0.13-3, mtu 1500
(In reply to Thomas Haller from comment #2) > I have lots of routes, thus outputting the routes is too verbose for my > usecase. Maybe omit that? They're on the other hand useful and it's not too typical to have too many of those. Beniamino seems to agree, so I'm keeping them. > Otherwise, lgtm (great improvement!). (In reply to Beniamino Galvani from comment #3) > Branch LGTM. Only minor consideration on the output: > > bond0: unmanaged > bond 3.7.1, B2:E4:F1:49:D4:0C, unmanaged, sw, fw 2, mtu 1500 > > Can we remove the second 'unmanaged'? Done. > Also, I find that the driver-version and the firmware-version don't > add useful information for users. Personally I would drop them; but > keep the routes :) Agreed; removed the versions. > I would also surround the description with double quotes or something > like that to make explicit that it's a free form field, but I guess > it's a matter of taste, feel free to ignore it. > > enp0s25: connected to enp0s25-static > "Intel Ethernet Connection I217-LM" > ethernet (e1000e), 54:EE:75:45:5A:53, hw, fw 0.13-3, mtu 1500 Good idea. Done. Merged.