After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766249 - housekeeping: few misc cleanups
housekeeping: few misc cleanups
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: housekeeping
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-11 00:09 UTC by Cosimo Cecchi
Modified: 2016-05-11 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
housekeeping: remove unused return value (2.07 KB, patch)
2016-05-11 00:09 UTC, Cosimo Cecchi 		committed Details | Review
housekeeping: remove unused parameter (2.58 KB, patch)
2016-05-11 00:09 UTC, Cosimo Cecchi 		committed Details | Review
housekeeping: simplify code (936 bytes, patch)
2016-05-11 00:09 UTC, Cosimo Cecchi 		committed Details | Review
housekeeping: split a method to send a notification (7.86 KB, patch)
2016-05-11 00:09 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-05-11 00:09:00 UTC 
These patches are part of a downstream patchset that adds another way to trigger the "out of space" notification, and I think they'd be nice to have upstream too.
Implementing the additional out of space mechanism requires the dconf patches in bug 766248 and I will open a separate bug with a patch if they get accepted.
Comment 1 Cosimo Cecchi 2016-05-11 00:09:03 UTC 
Created attachment 327621 [details] [review]
housekeeping: remove unused return value
Comment 2 Cosimo Cecchi 2016-05-11 00:09:07 UTC 
Created attachment 327622 [details] [review]
housekeeping: remove unused parameter
Comment 3 Cosimo Cecchi 2016-05-11 00:09:10 UTC 
Created attachment 327623 [details] [review]
housekeeping: simplify code
Comment 4 Cosimo Cecchi 2016-05-11 00:09:14 UTC 
Created attachment 327624 [details] [review]
housekeeping: split a method to send a notification

Other conditions can be introduced for this notification, so split it
out.
Comment 5 Bastien Nocera 2016-05-11 08:42:53 UTC 
Review of attachment 327621 [details] [review]:

Sure.
Comment 6 Bastien Nocera 2016-05-11 08:43:57 UTC 
Review of attachment 327622 [details] [review]:

OK.
Comment 7 Bastien Nocera 2016-05-11 08:45:06 UTC 
Review of attachment 327623 [details] [review]:

Yep.
Comment 8 Bastien Nocera 2016-05-11 09:00:22 UTC 
Review of attachment 327624 [details] [review]:

Looks fine.
Comment 9 Cosimo Cecchi 2016-05-11 17:06:18 UTC 
Attachment 327621 [details] pushed as 54ed831 - housekeeping: remove unused return value
Attachment 327622 [details] pushed as 74c72df - housekeeping: remove unused parameter
Attachment 327623 [details] pushed as 5ad0ff0 - housekeeping: simplify code
Attachment 327624 [details] pushed as c7efafa - housekeeping: split a method to send a notification

Thanks, pushed to master.