After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766240 - autotools-templates: add src/Makefile.am to empty template
autotools-templates: add src/Makefile.am to empty template
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: templates
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-10 19:52 UTC by Christian Hergert
Modified: 2016-05-11 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bug 766240 (2.91 KB, patch)
2016-05-11 16:54 UTC, Raunaq
none Details | Review
autotools-templates: add src/Makefile.am for empty template (2.91 KB, patch)
2016-05-11 17:53 UTC, Christian Hergert
committed Details | Review

Description Christian Hergert 2016-05-10 19:52:11 UTC
The autotools empty template does not include a src/Makefile.am because I thought doing so wouldn't be "empty enough". I've decided that is not true.

We need to add a src/Makefile.am to the templates. That probably requires doing two things.

The plugin can be found at plugins/autotools-templates/

1) add plugins/autotools-templates/autotools_templates/resources/src/Makefile.empty
  This file should be copied into src/Makefile.am
  It should be pretty clear how to do this based on other code in the __init__.py part of the plugin.

  The contents of the file should probably just be this single line:

  -include $(top_srcdir)/git.mk

2) Make sure src/Makefile.am is in the AC_OUTPUT section of 1) add plugins/autotools-templates/autotools_templates/resources/configure.ac

3) Make sure 1) add plugins/autotools-templates/autotools_templates/resources/Makefile.am includes src in the SUBDIRS.

Do a make install and then test that you can do something like:

 ide create-project -t empty foo
 cd foo
 ./autogen.sh
 make

and that the whole thing works as expected.
Comment 1 Raunaq 2016-05-11 16:54:14 UTC
Created attachment 327652 [details] [review]
Bug 766240

Incomplete, needs changes
Comment 2 Raunaq 2016-05-11 16:56:08 UTC
@hergertme : could u pls suugest the changes to be made and what is wrong..
Comment 3 Christian Hergert 2016-05-11 17:53:37 UTC
Created attachment 327654 [details] [review]
autotools-templates: add src/Makefile.am for empty template

This adds an empty src/Makefile.am for the empty autotools template.
Comment 4 Christian Hergert 2016-05-11 17:55:05 UTC
most of it turned out to just be removing old special cases i had in there for the empty project.

pushed with the couple small changes. thanks for working on this!

lets see if we can get you another bug to work on
Comment 5 Raunaq 2016-05-11 18:50:52 UTC
(In reply to Christian Hergert from comment #4)
> most of it turned out to just be removing old special cases i had in there
> for the empty project.
> 
> pushed with the couple small changes. thanks for working on this!
> 
> lets see if we can get you another bug to work on

Yes sure! Looking forward \m/