After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766145 - Cannot enter custom size
Cannot enter custom size
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
3.18.x
Other Linux
: High major
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-08 17:23 UTC by Yuri Khan
Modified: 2016-06-14 06:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Yuri Khan 2016-05-08 17:23:25 UTC
To reproduce:

1. Start a new game.
2. Click the Custom difficulty.
3. Focus the Height input box and try to enter the value 33 from the keyboard.

Expected behavior: the Height input box value is set to 33.

Observed behavior: a 30×16 game starts immediately when the digit 3 is pressed.

I strongly suspect these lines of code (gnome-mines.vala:275–278 in current master):

        set_accels_for_action ("app.small-size", {"1"});
        set_accels_for_action ("app.medium-size", {"2"});
        set_accels_for_action ("app.large-size", {"3"});
        set_accels_for_action ("app.custom-size", {"4"});
Comment 1 Michael Catanzaro 2016-05-22 15:47:00 UTC
Robert, got time to look into this one?
Comment 2 Robert Roth 2016-06-12 18:30:26 UTC
Yes, indeed, the code Yuri has pointed out was the issue, I have disabled the accels everywhere except for the new game screen, where they were meant to be used, and it solves the problem.
Sorry for the late answer, but better late then never, been quite busy with life lately :)
Comment 3 Michael Catanzaro 2016-06-12 19:15:28 UTC
Thanks Robert. Next step, got time to do a new 3.20 release for this? I can if you're busy.
Comment 4 Robert Roth 2016-06-12 21:06:48 UTC
I can, and will do it tomorrow.
Comment 5 Robert Roth 2016-06-14 06:48:51 UTC
Ok, I have prepared and pushed a 3.20.1 release with updated translations and a fix for this issue. It's up to the distribution packagers now to pull the changes.