GNOME Bugzilla – Bug 766026
Cerbero doesn't use my name/email when writing commits
Last modified: 2016-05-08 17:16:03 UTC
When I'm hacking on GStreamer modules, I write my code and commits into cerbero's checkout, so I can easily test my code. But it won't put my name/email on those commits, and use "Cerbero Build System <cerbero@gstreamer.freedesktop.org>" instead. That's a regression introduced by: https://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=17d4c4d64ca6947da6837fb119c94253d9e32b58
As I see it, cerbero is not really a system for 'hacking'. I'm not a fan of how it uses git here, but that's how it is. The commit was needed to make stuff work at all, but I agree it should be made optional based on whether a global name is set or not. Care to make a patch?
Created attachment 327349 [details] [review] cerbero/git: Only set user if none is already configured
(In reply to Tim-Philipp Müller from comment #1) > As I see it, cerbero is not really a system for 'hacking'. Not sure what it is then... ;-) > Care to make a patch? Sure!
Created attachment 327350 [details] [review] cerbero/git: Only set user if none is already configured
I think we should admit that there is some basic hacking ability that we use all the time when dealing with cerbero in real life projects. Specially when we need to test a small patch, going through recipe update with file bases patches all the time is not efficient.
Review of attachment 327350 [details] [review]: .
commit f465d7ba52b4633044d27eb21d2146f2431c76d1 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Thu May 5 09:52:02 2016 -0400 cerbero/git: Only set user if none is already configured https://bugzilla.gnome.org/show_bug.cgi?id=766026
Thanks Xavier!